-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: restructure cli commands to support different frameworks templates #618
Conversation
@sadeghbarati Tests are passing but can you help confirming everything works as expected π |
Sure, I appreciate the effort you put into β€οΈβπ₯ Will test tomorrow π |
https://stackblitz.com/edit/vitejs-vite-1fjqkm?file=package.json @MuhammadM1998 Sry for the late test, I tested the CLI the seems to have problem with the |
Thanks for testing π I'll see whats wrong and retest |
4796504
to
b271e1e
Compare
@sadeghbarati It was always running |
Closing this as it's outdated ππΌ |
The pr is outdated but the goal is still valid. the Nuxt module DX can be improved (auto imports, layers, etc..). Is that acceptable to you? I can rework an updated PR if so. |
π Linked issue
#570
β Type of change
π Description
POC of #570. This PR just extracts the vue-specific code
init
,add
,diff
commands into their respective commands incommands/frameworks/vue
folder and update the imports accordingly. No other changes were made for easier reviewing.Remarks:
getConfig
has been extracted to its separate file too because in the Nuxt module we'd read the config differently (think reading components config from nuxt.config instead of components.json). Hence it's extracted to a reusable function to be used in all commands when needed.vue
commands fornuxt
to ensure everything works as expected. Next step is creating nuxt-specific commands and use those instead.πΈ Screenshots (if appropriate)
π Checklist